Skip to content

ValidationView: reimplementation part 1 - #2639

Merged
mariusheine merged 4 commits into
mainfrom
reimplementation-validation-view
Aug 26, 2026
Merged

ValidationView: reimplementation part 1#2639
mariusheine merged 4 commits into
mainfrom
reimplementation-validation-view

Conversation

@TruongQuangSB

@TruongQuangSB TruongQuangSB commented Aug 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

ValidationView: replace EMF Forms ModelView with native Eclipse UI and SWT widgets

@TruongQuangSB TruongQuangSB changed the title ValidationView: replace EMF Forms ModelView ValidationView: reimplementation part 1 Aug 24, 2026
@github-actions

github-actions Bot commented Aug 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Test Results

147 tests  ±0   147 ✅ ±0   3m 59s ⏱️ + 1m 57s
 40 suites ±0     0 💤 ±0 
 40 files   ±0     0 ❌ ±0 

Results for commit db4d0c7. ± Comparison against base commit 0b5b990.

This pull request removes 8 and adds 8 tests. Note that renamed tests count towards both. 
org.eclipse.set.feature.plazmodel.test.CalculateTopologicalCoordinateTest ‑ testTopologischeCoordinateCalculate(Pair)[1] Pair [first=pphn, second=/tmp/set-test1200548761422905567PPHN_1.10.0.3_01-02_Ibn-Z._-_2._AeM_2022-05-17_13-44_tg3.planpro]
org.eclipse.set.feature.siteplan.transform.SiteplanTransformatorTest ‑ testSiteplanTransformSuccessful(String)[1] /tmp/set-test10996817101561898607PPHN_1.10.0.3_01-02_Ibn-Z._-_2._AeM_2022-05-17_13-44_tg3.planpro
org.eclipse.set.feature.table.pt1.test.Pt1TableTransformationTest ‑ testTransformator(String)[1] /tmp/set-test15907676247347069942PPHN_1.10.0.3_01-02_Ibn-Z._-_2._AeM_2022-05-17_13-44_tg3.planpro
org.eclipse.set.feature.table.pt1.test.Pt1TableTransformationTest ‑ testTransformator(String)[2] /tmp/set-test10047748591294535110Info__2026-04-21_10-40.planpro
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKey(TestData)[1] TestData [input=org.eclipse.set.model.planpro.Weichen_und_Gleissperren.impl.W_Kr_Gsp_ElementImpl@6604f246, expected=multi/container-id/1796226487/element-id]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKey(TestData)[2] TestData [input=org.eclipse.set.model.planpro.Signale.impl.SignalImpl@c89e263, expected=multi/456/521328096/123]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKeyOther(TestData)[1] TestData [input=Pair [first=org.eclipse.set.model.planpro.Weichen_und_Gleissperren.impl.W_Kr_Gsp_ElementImpl@11c25846, second=other], expected=multi/container-id/615747215/element-id/other=other]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKeyOther(TestData)[2] TestData [input=Pair [first=org.eclipse.set.model.planpro.Signale.impl.SignalImpl@7f3e9acc, second=xxx], expected=multi/456/1033669692/123/other=xxx]

org.eclipse.set.feature.plazmodel.test.CalculateTopologicalCoordinateTest ‑ testTopologischeCoordinateCalculate(Pair)[1] Pair [first=pphn, second=/tmp/set-test11321018533663617543PPHN_1.10.0.3_01-02_Ibn-Z._-_2._AeM_2022-05-17_13-44_tg3.planpro]
org.eclipse.set.feature.siteplan.transform.SiteplanTransformatorTest ‑ testSiteplanTransformSuccessful(String)[1] /tmp/set-test10421227899013604760PPHN_1.10.0.3_01-02_Ibn-Z._-_2._AeM_2022-05-17_13-44_tg3.planpro
org.eclipse.set.feature.table.pt1.test.Pt1TableTransformationTest ‑ testTransformator(String)[1] /tmp/set-test984911701015408383PPHN_1.10.0.3_01-02_Ibn-Z._-_2._AeM_2022-05-17_13-44_tg3.planpro
org.eclipse.set.feature.table.pt1.test.Pt1TableTransformationTest ‑ testTransformator(String)[2] /tmp/set-test14474707218342046218Info__2026-04-21_10-40.planpro
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKey(TestData)[1] TestData [input=org.eclipse.set.model.planpro.Weichen_und_Gleissperren.impl.W_Kr_Gsp_ElementImpl@c1386b4, expected=multi/container-id/187712237/element-id]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKey(TestData)[2] TestData [input=org.eclipse.set.model.planpro.Signale.impl.SignalImpl@4d5ea776, expected=multi/456/1711600198/123]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKeyOther(TestData)[1] TestData [input=Pair [first=org.eclipse.set.model.planpro.Weichen_und_Gleissperren.impl.W_Kr_Gsp_ElementImpl@460b77d6, second=other], expected=multi/container-id/1559261930/element-id/other=other]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKeyOther(TestData)[2] TestData [input=Pair [first=org.eclipse.set.model.planpro.Signale.impl.SignalImpl@47d4e28a, second=xxx], expected=multi/456/768028708/123/other=xxx]

♻️ This comment has been updated with latest results.

mariusheine
mariusheine requested changes Aug 25, 2026
View reviewed changes
Comment thread ...ipse.set.feature.validation/src/org/eclipse/set/feature/validation/parts/ValidationPart.java Outdated
@mariusheine
mariusheine merged commit 4761a58 into main Aug 26, 2026
17 checks passed
@mariusheine
mariusheine deleted the reimplementation-validation-view branch August 26, 2026 00:04
TruongQuangSB added a commit to SuB-PlanPro/set that referenced this pull request Aug 26, 2026
@TruongQuangSB
ValidationView: reimplementation part 1 (eclipse-set#2639)
ad86aab 
* ValidationView: replace EMF Forms ModelView with native Eclipse UI and SWT widgets

* fix compile

* fix missing label

* Remove comment code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariusheine mariusheine mariusheine approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TruongQuangSB @mariusheine